This repository has been archived by the owner on Oct 4, 2022. It is now read-only.
Introduces the @yoast/components package #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 15 commits
March 13, 2019 10:17
* develop: (266 commits) Update yarn lock Fix typo in comment in a German morphology stem file Improve code style Fix ESLint errors Don't debounce in the example Move addVariable button to variable Improve code style Updated parameter types of JSDoc of Headings research functions. Update .gitignore Removed blank line padding. Headings research does not return null or the node, but the empty list or a list with one item. Remove empty test script Add missing comma Added test case for a tree with no headings. Created Headdings researcher. Publish Add 4.22.0 changelog Add prepublishOnly scripts to both packages Centralize dist ignore rule Move CSS files to more specific folder ...
* develop: Fix code style Add German transition words Fix typos in German morphology files
|
All dependencies need to be added to |
added 3 commits
March 18, 2019 13:19
atimmer
suggested changes
Mar 18, 2019
packages/components/ErrorBoundary.js
Outdated
| @@ -6,7 +6,7 @@ import { __ } from "@wordpress/i18n"; | |||
| import { speak as a11ySpeak } from "@wordpress/a11y"; | |||
|
|
|||
| /* Internal dependencies */ | |||
| import colors from "../../style-guide/colors"; | |||
| import colors from "../yoast-components/style-guide/colors"; | |||
There was a problem hiding this comment.
We should have no dependencies on yoast-components in @yoast/components. So that means we should probably move colors to @yoast/components.
added 6 commits
March 18, 2019 14:19
added 2 commits
March 18, 2019 16:03
* develop: Direct users to the right place Make sure that the app uses components from the packages, not with a relative path First working app version :D Trying to get the app to work; status: unsuccesful and frustrated... Initial move of the yoast-components-app Add install-ci to the pretest instead of the test Init @yoast/social-metadata-previews package Make sure that yoastseo yarn test installs the preium-configuration as this is required for the test Publish Add handy lerna scripts Add prepublish to ESLint Add publish command to scripts Fix ESLint error # Conflicts: # apps/components/App.js # apps/components/ButtonsWrapper.js # apps/components/ComponentsExample.js # apps/components/ExamplesContainer.js # apps/components/HelpCenterWrapper.js # apps/components/SidebarCollapsibleWrapper.js # apps/components/SvgIconsWrapper.js
diedexx
approved these changes
Mar 18, 2019
packages/yoast-components/index.js
Outdated
| @@ -27,7 +26,7 @@ import { default as LinkSuggestions } from "./composites/LinkSuggestions/LinkSug | |||
| // Composites/KeywordSuggestions imports. | |||
| import { default as KeywordSuggestions } from "./composites/KeywordSuggestions/KeywordSuggestions"; | |||
| // Composites/basic imports. | |||
| import { default as Loader } from "./composites/basic/Loader"; | |||
| import { default as Loader } from "../components/Loader"; | |||
There was a problem hiding this comment.
Can this be written as "@yoast/components/Loader`?
There was a problem hiding this comment.
This is something that needs to be changed.
|
Also, the build is still failing. |
diedexx
suggested changes
Mar 19, 2019
| @@ -1,4 +1,4 @@ | |||
| @import "../../style-guide/colors"; | |||
| @import "../../../components/style-guide/colors"; | |||
| @@ -1,4 +1,4 @@ | |||
| @import "accessibility"; | |||
| @import "../composites/OnboardingWizard/onboarding-wizard"; | |||
| @import "../composites/basic/loader"; | |||
| @import "../../components/loader"; | |||
bintzandt
force-pushed
the
30-create-components-package
branch
from
443f500
to
77c422b
Compare
bintzandt
force-pushed
the
30-create-components-package
branch
from
77c422b
to
a7e7e74
Compare
diedexx
approved these changes
Mar 19, 2019
Conflicts: packages/components/Explanation.js packages/components/composites/Textfield.js packages/configuration-wizard/StepButton.js packages/configuration-wizard/components/Choice.js packages/configuration-wizard/components/Explanation.js packages/configuration-wizard/components/StepComponents.js packages/configuration-wizard/config/yoast-theme.js packages/configuration-wizard/onboarding-wizard.scss packages/yoast-components/composites/OnboardingWizard/StepButton.js packages/yoast-components/composites/OnboardingWizard/components/Choice.js packages/yoast-components/composites/OnboardingWizard/components/Explanation.js packages/yoast-components/composites/OnboardingWizard/components/StepComponents.js packages/yoast-components/composites/OnboardingWizard/config/yoast-theme.js packages/yoast-components/composites/OnboardingWizard/onboarding-wizard.scss packages/yoast-components/css/all.scss packages/yoast-components/forms/composites/Textfield.js
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #30
Makes sure
yarn lintandyarn testwill have the same output as on thedevelopbranch