Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modernize: use __DIR__ instead of dirname( __FILE__ ) #129

Merged
merged 1 commit into from
May 1, 2023

Conversation

jrfnl
Copy link
Contributor

@jrfnl jrfnl commented May 1, 2023

As support for PHP < 5.3 has been dropped (in PR #96), the __DIR__ constant can be safely used.

As support for PHP < 5.3 has been dropped (in PR 96), the `__DIR__` constant can be safely used.
@jrfnl jrfnl added this to the 1.x Next Release milestone May 1, 2023
@coveralls
Copy link

Pull Request Test Coverage Report for Build 4854785027

  • 0 of 2 (0.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 22.609%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/Whip_MessagesManager.php 0 1 0.0%
src/facades/wordpress.php 0 1 0.0%
Totals Coverage Status
Change from base Build 4854712312: 0.0%
Covered Lines: 52
Relevant Lines: 230

💛 - Coveralls

@jrfnl jrfnl merged commit b991d65 into main May 1, 2023
@jrfnl jrfnl deleted the JRF/modernize-dirname-file branch May 1, 2023 20:49
@enricobattocchi enricobattocchi modified the milestones: 1.x Next Release, 2.0 Oct 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants