Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CS errors and adapt threshold #159

Merged
merged 3 commits into from
Dec 22, 2023
Merged

Fix CS errors and adapt threshold #159

merged 3 commits into from
Dec 22, 2023

Conversation

enricobattocchi
Copy link
Member

No description provided.

@enricobattocchi enricobattocchi added this to the 2.0 milestone Dec 22, 2023
@enricobattocchi enricobattocchi marked this pull request as ready for review December 22, 2023 14:14
@enricobattocchi enricobattocchi changed the title Fix CS errors and set threshold to 2. Fix CS errors and adapt threshold Dec 22, 2023
@coveralls
Copy link

coveralls commented Dec 22, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 7301049581

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 31.683%
Totals Coverage Status
Change from base Build 7300735247: 0.0%
Covered Lines: 96
Relevant Lines: 303
💛 - Coveralls

enricobattocchi and others added 2 commits December 22, 2023 15:40
@enricobattocchi
Add PHPCS disabling for two classnames that we want to preserve
262b39f
@jrfnl
Revert "GH Action/cs: use the threshold/branch report"
67a38ab 
No need to check via thresholds anymore as the CS issues have been brought down to 0 again.
@jrfnl jrfnl merged commit b56c9ca into main Dec 22, 2023
17 checks passed
@jrfnl jrfnl deleted the fix-cs-errors branch December 22, 2023 14:49
@enricobattocchi enricobattocchi mentioned this pull request Dec 27, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrfnl jrfnl jrfnl approved these changes

Assignees
No one assigned
Labels
yoast cs/qa
Projects
None yet
Milestone
2.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@enricobattocchi @coveralls @jrfnl