Exclude `VariableAnalysis.CodeAnalysis.VariableAnalysis.UnusedVariabl…

…e` for deprecated code
Yoast · May 3, 2024 · 72c241e · 72c241e
1 parent 8a73452
commit 72c241e
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/.phpcs.xml.dist b/.phpcs.xml.dist
@@ -227,6 +227,12 @@
 		<exclude-pattern>/inc/wpseo-functions-deprecated\.php$</exclude-pattern>
 	</rule>
 
+	<!-- Ignore unused variables in deprecated functionality. -->
+	<rule ref="VariableAnalysis.CodeAnalysis.VariableAnalysis.UnusedVariable">
+		<exclude-pattern>/src/deprecated/*</exclude-pattern>
+		<exclude-pattern>/inc/wpseo-functions-deprecated\.php$</exclude-pattern>
+	</rule>
+
 	<!-- Exclude deprecated code from select sniffs regarding naming conventions.
 		 These classes are still available to prevent BC-breaks and renaming them would
 		 create a BC-break. -->

diff --git a/composer.json b/composer.json
@@ -93,7 +93,7 @@
 		],
 		"check-cs-thresholds": [
 			"@putenv YOASTCS_THRESHOLD_ERRORS=2545",
-			"@putenv YOASTCS_THRESHOLD_WARNINGS=267",
+			"@putenv YOASTCS_THRESHOLD_WARNINGS=253",
 			"Yoast\\WP\\SEO\\Composer\\Actions::check_cs_thresholds"
 		],
 		"check-cs": [