Output escaping: Replace attribute keys escaping from esc_html to san…

…itize_key See also: WordPress/WordPress-Coding-Standards#1786
Yoast · Aug 2, 2019 · 921b5a0 · 921b5a0
1 parent 164f41f
commit 921b5a0
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/admin/views/class-yoast-form-fieldset.php b/admin/views/class-yoast-form-fieldset.php
@@ -175,6 +175,6 @@ private function get_attributes_html( $attributes ) {
 	 * @param string $attribute The attribute to look for.
 	 */
 	private function parse_attribute( & $value, $attribute ) {
-		$value = sprintf( '%s="%s"', esc_html( $attribute ), esc_attr( $value ) );
+		$value = sprintf( '%s="%s"', sanitize_key( $attribute ), esc_attr( $value ) );
 	}
 }
diff --git a/admin/views/class-yoast-input-select.php b/admin/views/class-yoast-input-select.php
@@ -135,6 +135,6 @@ private function get_attributes() {
 	 * @param string $attribute The attribute to look for.
 	 */
 	private function parse_attribute( & $value, $attribute ) {
-		$value = sprintf( '%s="%s"', esc_html( $attribute ), esc_attr( $value ) );
+		$value = sprintf( '%s="%s"', sanitize_key( $attribute ), esc_attr( $value ) );
 	}
 }