EscapeOutput: add sanitize_key() to escaping functions #1786
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dingo-d
approved these changes
Aug 1, 2019
igorschoester
added a commit
to Yoast/wordpress-seo
that referenced
this pull request
Aug 1, 2019
`sanitize_key()` only allows for lowercase characters, numbers, underscore and dash characters. So a variable run through `sanitize_key()` can be considered just as safe, if not more so, than a variable run through one of the escaping functions. Ref: * https://developer.wordpress.org/reference/functions/sanitize_key/
jrfnl
force-pushed
the
feature/escapeoutput-allow-sanitizekey
branch
from
36f1980
to
a8ad671
Compare
GaryJones
approved these changes
Aug 1, 2019
igorschoester
added a commit
to Yoast/wordpress-seo
that referenced
this pull request
Aug 2, 2019
igorschoester
added a commit
to Yoast/wordpress-seo
that referenced
this pull request
Aug 2, 2019
igorschoester
added a commit
to Yoast/wordpress-seo
that referenced
this pull request
Aug 2, 2019
4 tasks
igorschoester
added a commit
to Yoast/wordpress-seo
that referenced
this pull request
Sep 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sanitize_key()only allows for lowercase characters, numbers, underscore and dash characters. So a variable run throughsanitize_key()can be considered just as safe, if not more so, than a variable run through one of the escaping functions.Ref: