Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom Gutenberg blocks icons should be bigger #10838

Open
afercia opened this issue Aug 29, 2018 · 4 comments
Open

Custom Gutenberg blocks icons should be bigger #10838

afercia opened this issue Aug 29, 2018 · 4 comments

Comments

@afercia
Copy link
Contributor

afercia commented Aug 29, 2018

The How-to and FAQ block icons use Dashicons with their default size of 20 by 20 pixels.

However, Gutenberg recently refactored the block icons and made them bigger (24 by 24). Now the different size is very evident in the blocks suggestions, as also the text is misaligned.

screen shot 2018-08-29 at 11 13 32

Note: the difference is visible also in the Sidebar block description.

RIght now, the new Gutenberg block icons are hardcoded and there's no component to standardize them. SO maybe we should wait and see if that happens. See for example WordPress/gutenberg#9299 (review)

@afercia
Copy link
Contributor Author

afercia commented Aug 29, 2018

See also WordPress/gutenberg#9372

@afercia afercia changed the title Cusotm Gutenberg blocks icons should be bigger Custom Gutenberg blocks icons should be bigger Aug 29, 2018
@Djennez
Copy link
Member

Djennez commented Aug 8, 2019

Seems to no longer be an issue:

image

WP 5.2.2
Yoast Premium 11.9-RC1

@Djennez Djennez closed this as completed Aug 8, 2019
@afercia
Copy link
Contributor Author

afercia commented Aug 8, 2019

Almost 🙂
While in the suggestions list some new Gutenberg CSS aligns the icons regardless of their size, our icons are still smaller and that's visible in the sidebar block descriptions:

Screenshot 2019-08-08 at 16 11 54

Veeery minor though, will leave it up to you! On the other hand, making our icons 24 x 24 wouldn't be a terrible effort, I guess.

@Djennez
Copy link
Member

Djennez commented Aug 9, 2019

Dang! Missed that one! Thanks, will reopen.

@Djennez Djennez reopened this Aug 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants