Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Local for Woo from the extensions page #11562

Merged
merged 5 commits into from
Nov 14, 2018

Conversation

moorscode
Copy link
Contributor

@moorscode moorscode commented Nov 12, 2018

Adjust the copy of the Local SEO upsells to include the important Local SEO for Woo entry.

Summary

This PR can be summarized in the following changelog entry:

  • Removes Local SEO for WooCommerce from the Premium page as this plugin is merged into Local SEO since 9.2.

Relevant technical choices:

  • N/A

Test instructions

This PR can be tested by following these steps:

  • Go to the Premium page under SEO
  • See Local SEO for WooCommerce is no longer there
  • See the Local SEO upsells being updated
  • See the order of extensions being changed

Quality assurance

  • I have tested this code to the best of my abilities
  • I have added unittests to verify the code works as intended

Fixes #11561

Adjust the copy of the Local SEO upsells to include the important Local SEO for Woo entry.
Introduce get_display_title to change the heading for the extension without breaking the license logic internally
Copy link
Contributor

@IreneStr IreneStr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR 🚧

)
)
);

if ( ! defined( 'WPSEO_LOCAL_WOOCOMMERCE_VERSION' ) ) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove

@IreneStr IreneStr added this to the 9.2 milestone Nov 14, 2018
@IreneStr IreneStr merged commit 2718941 into release/9.2 Nov 14, 2018
@IreneStr IreneStr deleted the 11561-remove-local-for-woo-extension branch November 14, 2018 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants