Fix configuration wizard on release #12655
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When two different multi-builds of webpack use the same commons chunk they will go wrong because of the module cache. This results in all kinds of bugs.
We need to babelify parse5, because it contains code that isn't IE11 compatible. And they don't publish a babelified bundle.
This was referenced Apr 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR can be summarized in the following changelog entry:
The configuration wizard was broken when running
grunt releasebuild. This has been fixed with this PR. Also other issues should be fixed with this.Relevant technical choices:
Test instructions
This PR can be tested by following these steps:
grunt artifact.UI changes
Quality assurance
Fixes #12636
Fixes #12641