Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate yoast_plugin_compatibility_notification and related code #13497

Merged
merged 2 commits into from
Sep 23, 2019

Conversation

IreneStr
Copy link
Contributor

Summary

This PR can be summarized in the following changelog entry:

  • Removes the notification that would be thrown if add-ons with a lower version number than the plugin were installed. The yoast_plugin_compatibility_notification method has been deprecated.

Relevant technical choices:

Test instructions

This PR can be tested by following these steps:

  • Install add-on versions below 12.2.
  • Install the Yoast test helper.
  • Go to trunk (or if RC-testing: use a pre-12.3 zip) of wordpress-seo. Build everything, and go to the Yoast Notification center. See that there are notifications under Problems about old add-on versions.
  • Switch to this branch.
  • If acceptance testing this: change if ( version_compare( $version, '12.3-RC0', '<' ) ) { in inc/class-upgrade.php to if ( version_compare( $version, '12.1-RC0', '<' ) ) {
    • You don't need to do this step if you're RC-testing the 12.3-RCx zip.
  • In the test helper, set the database to an old version, e.g. 10.0, and click save. This will trigger the upgrade routine.
  • Go back to the dashboard and see that the notifications are gone.

UI changes

  • This PR changes the UI in the plugin. I have added the 'UI change' label to this PR.

Documentation

  • I have written documentation for this change.

Quality assurance

  • I have tested this code to the best of my abilities
  • I have added unittests to verify the code works as intended

Fixes #13485

@IreneStr IreneStr added the changelog: other Needs to be included in the 'Other' category in the changelog label Sep 18, 2019
inc/class-upgrade.php Outdated Show resolved Hide resolved
@igorschoester
Copy link
Member

Acceptance ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog: other Needs to be included in the 'Other' category in the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove the yoast_plugin_compatibility_notification
3 participants