Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added grunt webpack:watch task #15984

Merged
merged 1 commit into from
Sep 2, 2020
Merged

Conversation

abotteram
Copy link
Contributor

Context

  • Create an easier way to work with javascript without YOAST_SEO_DEV_SERVER.

Summary

This PR can be summarized in the following changelog entry:

  • Adds a grunt webpack:watch task that quickly rebuilds javascript when changing a js file without having to run grunt build:js again.

Relevant technical choices:

Test instructions

This PR can be tested by following these steps:

  • Run grunt webpack:watch.
  • Make a change to a JS file which you can easily see (like adding a console.log to admin-global.js), and save it.
  • See that grunt webpack:watch almost instantly rebuilds the javascript.
  • Reload the browser to see the change you made.

UI changes

  • This PR changes the UI in the plugin. I have added the 'UI change' label to this PR.

Documentation

  • I have written documentation for this change.

Quality assurance

  • I have tested this code to the best of my abilities
  • I have added unittests to verify the code works as intended

Fixes #

@abotteram abotteram added build tooling changelog: non-user-facing Needs to be included in the 'Non-userfacing' category in the changelog labels Sep 2, 2020
@hansjovis hansjovis self-assigned this Sep 2, 2020
Copy link
Contributor

@hansjovis hansjovis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: 👍

@hansjovis
Copy link
Contributor

Acceptance test: ✅

Indeed a lot faster than grunt build-watch 🎉 .

@hansjovis hansjovis merged commit 37bcc34 into trunk Sep 2, 2020
@hansjovis hansjovis deleted the add-grunt-webpack-watch-task branch September 2, 2020 07:31
@IreneStr IreneStr added this to the 15.1 milestone Sep 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build tooling changelog: non-user-facing Needs to be included in the 'Non-userfacing' category in the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants