Travis: run CS in separate workflow & other minor tweaks #16903
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Summary
This PR can be summarized in the following changelog entry:
Relevant technical choices:
As discussed in Slack this updates the Travis script to run the CS check in its own workflow.
Includes minor other tweaks and clean up.
For the record: this was the PHPCS PR which caused the difference in reported issues: squizlabs/PHP_CodeSniffer#2925
Composer: update lock file
.. to get rid of the
The lock file is not up to date with the latest changes in composer.json. You may be getting outdated dependencies.
warning.Travis: remove cruft remaining after Premium split-off
Remove ENV variable declaration and conditions which are no longer necessary since the Premium plugin has been split off and now has its own script.
Travis: run CS checks in a separate build
... with its own simplified build steps.
Composer: update the CS threshold numbers
Test instructions
Test instructions for the acceptance test before the PR gets merged
This PR can be acceptance tested by following these steps:
composer install
composer check-cs-thresholds
and confirm that the threshold numbers are 100% correct.PHP 7.4: check CS
run.3.5.8
.