Changes the way we decide which content types are displayed in the settings. #19603
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
I added the same check for both taxonomies and custom post types because in both cases we sometimes don't create indexable. For example if they are not set public or excluded via one of our filters. I these cases we also do not want to display them in the menu sidebar because it does not make sense to optimise a page that is not indexed in the first place.
The check implemented is exactly the same as the check used to determine if a cpt or tax should be an indexable.
Summary
This PR can be summarized in the following changelog entry:
Relevant technical choices:
if
check.Test instructions
Test instructions for the acceptance test before the PR gets merged
This PR can be acceptance tested by following these steps:
Make sure elementor is enabled.
Without this PR you should see a
my templates
content type in https://wordpress.test/wp-admin/admin.php?page=wpseo_page_settings#/site-featuresCheckout this PR. The
My templates
should be gone.Make sure all your public post types are still there.
add a public taxonomy with a plugin like
custom cpt
and make sure it shows up in theCategories & tags
section.Make the taxonomy non public and make sure it is no longer there.
Relevant test scenarios
Test instructions for QA when the code is in the RC
QA can test this PR by following these steps:
Impact check
This PR affects the following parts of the plugin, which may require extra testing:
UI changes
Other environments
[shopify-seo]
, added test instructions for Shopify and attached theShopify
label to this PR.Documentation
Quality assurance
Innovation
innovation
label and noted the work hours.Fixes #