Validate if the element is not a false

[jaimearroyonavia]

Context

We use themosis 3, ACF and Yoast SEO, and without this the ACF list of group fields doesn't works

Summary

changelog: bugfix

Fixes a bug where some exceptions on build method of Indexable_Repository class return a false:

• https://github.com/Yoast/wordpress-seo/blob/trunk/src/builders/indexable-builder.php#L429
• https://github.com/Yoast/wordpress-seo/blob/trunk/src/builders/indexable-builder.php#L455

and this is not verified before try to access to the object_id property here https://github.com/Yoast/wordpress-seo/blob/trunk/src/integrations/admin/admin-columns-cache-integration.php#L112 this would validate if is not a false type.

Relevant technical choices:

Themosis 3
Wordpress 6.2.2
ACF 6.1.7
Yoast 20.11

PHP 8.2

Test instructions

Test instructions for the acceptance test before the PR gets merged

This PR can be acceptance tested by following these steps:

• Create a project with themosis
• Enable both plugins
• Crate a group of ACF
• Then access to the admin of ACF group fields and the list is not appearing.

Relevant test scenarios

• Changes should be tested with the browser console open
• Changes should be tested on different posts/pages/taxonomies/custom post types/custom taxonomies
• [] Changes should be tested on different editors (Block/Classic/Elementor/other)
• Changes should be tested on different browsers
• Changes should be tested on multisite

Test instructions for QA when the code is in the RC

• QA should use the same steps as above.

QA can test this PR by following these steps:

Impact check

This PR affects the following parts of the plugin, which may require extra testing:

UI changes

• This PR changes the UI in the plugin. I have added the 'UI change' label to this PR.

Other environments

• This PR also affects Shopify. I have added a changelog entry starting with [shopify-seo], added test instructions for Shopify and attached the Shopify label to this PR.

Documentation

• I have written documentation for this change.

Quality assurance

• I have tested this code to the best of my abilities.
• [ X] During testing, I had activated all plugins that Yoast SEO provides integrations for.
• I have added unit tests to verify the code works as intended.
• If any part of the code is behind a feature flag, my test instructions also cover cases where the feature flag is switched off.
• I have written this PR in accordance with my team's definition of done.
• I have checked that the base branch is correctly set.

Fixes #

[thijsoo]

Hi @jaimearroyonavia Thank you for opening this pr! I have copied your changes to this PR and added some more context for our process. And of course given you props for the fix :)

[jaimearroyonavia]

@thijsoo thanks, look so much better.

[mhkuu]

Let's then close this one as it's covered in #20529 😄 Thanks again!