-
Notifications
You must be signed in to change notification settings - Fork 887
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't overwrite user settings when the respective features are disabled #21314
Don't overwrite user settings when the respective features are disabled #21314
Conversation
Pull Request Test Coverage Report for Build 8b43089c625103ac862fa11105ec20207cf5705aWarning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
…lobal-features-are-toggled
…-wiped-out-if-global-features-are-toggled
8e4ef5b
to
ed8b656
Compare
ed8b656
to
9a4a1a3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CR 🏗️ ❓
src/user-meta/framework/custom-meta/content-analysis-disable.php
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CR 👍
Context
Summary
This PR can be summarized in the following changelog entry:
WPSEO_Admin_User_Profile::user_profile()
method and theadmin/views/user-profile.php
file.Relevant technical choices:
src/user-meta
directory and deprecated a bunch of older stuff.Test instructions
Test instructions for the acceptance test before the PR gets merged
This PR can be acceptance tested by following these steps:
The user settings that we're interested in, along with their relations with global settings, are:
Enable author archives
global settingEnable author archives
global feature settingSEO analysis
global feature setting is enabledReadability analysis
global feature settingInclusive language analysis
global feature settingAccording to the above, for every setting the test is
Enable author archives
(or any of the other respective global feature settings, mentioned above)Show Toolbar when viewing site
setting )Enable author archives
settingWith this PR/RC:
Before this PR/RC:
the Title to use for Author page setting has no value
What is more, smoke test that the user settings in the User->Profile page stays the same visually:
Relevant test scenarios
Test instructions for QA when the code is in the RC
Impact check
This PR affects the following parts of the plugin, which may require extra testing:
Title to use for Author page
):title
field to be the one we have in the user profile, no matter if the respective global setting is enabled or not.Meta description to use for Author page
):description
field to be the one we have in the user profile, no matter if the respective global setting is enabled or not.Do not allow search engines to show this author's archives in search results
):is_robots_noindex
field to be the one we have in the user profile, no matter if the respective global setting is enabled or not.Disable SEO analysis
):Disable SEO analysis
checkbox has been checked or not. Try while toggling the global SEO analysis feature as well.Disable inclusive language analysis
):Disable inclusive language analysis
checkbox has been checked or not. Try while toggling the global inclusive language feature as well.Disable readability analysis
):Disable readability analysis
checkbox has been checked or not. Try while toggling the global readability analysis feature as well.UI changes
Other environments
[shopify-seo]
, added test instructions for Shopify and attached theShopify
label to this PR.Documentation
Quality assurance
Innovation
innovation
label.Fixes #21313