-
Notifications
You must be signed in to change notification settings - Fork 882
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor breadcrumbs class - fixes a number of bugs #833
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…factor-breadcrumbs-class
…factor-breadcrumbs-class
…factor-breadcrumbs-class
…factor-breadcrumbs-class
…factor-breadcrumbs-class Conflicts: readme.txt
…factor-breadcrumbs-class
…factor-breadcrumbs-class
With the changes to v1.5, the defaults for some of the textual breadcrumb settings are added dynamically, but empty strings are allowed. This caused issues for people who left the fields empty on purpose relying on the defaults.
…factor-breadcrumbs-class
Can't automerge this and due to the number of commits I'd feel better if you merged yourself @jrfnl :) |
…factor-breadcrumbs-class Conflicts: readme.txt
jrfnl
added a commit
that referenced
this pull request
Mar 17, 2014
Refactor breadcrumbs class - fixes a number of bugs
Done, it was only the readme conflicting after the updates of this morning. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues fixed:
<span>
's and suchyoast_breadcrumbs()
used to be either the breadcrumb string or true, with v1.5 it became string or null. Fixed to be the same as before again.This will hopefully solve at least some issues with themes.
This will also solve some issues where people didn't see the breadcrumb because the default 'Home' text for instance wasn't available. These issues may have incorrectly been blamed on theme integration.
@dannyvankooten This refactor should make it lot easier to write unit tests for this class. Hope you like it ;-)
Related issues #631, #795, #811, #816.
Also:
http://wordpress.org/support/topic/conflict-with-weaver-pro-theme-breadcrumbs-not-showing