Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-enable the WordPress.Variables.GlobalVariables sniff #20

Closed
jrfnl opened this issue Dec 31, 2016 · 2 comments
Closed

Re-enable the WordPress.Variables.GlobalVariables sniff #20

jrfnl opened this issue Dec 31, 2016 · 2 comments
Assignees
Milestone

Comments

@jrfnl
Copy link
Collaborator

jrfnl commented Dec 31, 2016

The WordPress.Variables.GlobalVariables sniff was originally part of the intended ruleset, but turned off because of its buggyness as reported in WordPress/WordPress-Coding-Standards#300.
See: https://github.com/Yoast/yoastcs/blob/master/Yoast/ruleset.xml#L48

All the currently known bugs are expected to be fixed in the near future once WordPress/WordPress-Coding-Standards#736 is merged.

It is expected that the PR will be part of the next WPCS release 0.11.0.

So I'd like to suggest re-enabling the sniff once WPCS 0.11.0 has been released and the minimum WPCS requirement in the Yoast CS composer.json has been upped to 0.11.0.

@jrfnl
Copy link
Collaborator Author

jrfnl commented Jan 7, 2017

Update: the PR to fix the bugs in WPCS has been merged and will be part of the 0.11.0 release.

@jrfnl
Copy link
Collaborator Author

jrfnl commented Mar 21, 2017

Update: WPCS 0.11.0 has been released.

@jrfnl jrfnl self-assigned this Aug 2, 2017
@jrfnl jrfnl added this to the 0.5.x milestone Nov 3, 2017
@moorscode moorscode modified the milestones: 0.5.x, 1.0.0, 0.5.0 Aug 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants