Use a more appropriate ruleset. #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrfnl
force-pushed
the
JRF/fix-ruleset
branch
from
1095e9f
to
7170dc1
Compare
jrfnl
force-pushed
the
JRF/fix-ruleset
branch
from
7170dc1
to
a13dac9
Compare
|
Rebased for merge conflicts |
Note: * As the WordPress ruleset includes all WP sniffs, specific sniffs which were not in the VIP ruleset don't need to be included separately anymore. * As the WordPress ruleset includes the Docs ruleset, no need to include it separately. The related rule exclusions have been moved up to the main ruleset inclusion block (except for the scalar type hint one as that is no longer needed). * The GlobalVariables sniff was intended to be added, but commented out for bugs. As it will now be automatically included as the ruleset has changed, it will need to be explicitely excluded. The exclusion can be removed once WPCS 0.11.0 has been released which fixes all known bugs in that sniff.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #16
[Edit] The PR has been updated with a review of current extra rule inclusions/exclusions which are no longer needed if the main ruleset changes.