Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Readme: update the text #147

Merged
merged 3 commits into from
Jul 31, 2019
Merged

Readme: update the text #147

merged 3 commits into from
Jul 31, 2019

Conversation

jrfnl
Copy link
Collaborator

@jrfnl jrfnl commented Jul 25, 2019

The text in the readme was a bit dated.

Includes adding instructions on how to view the "end-user" docs for the PHPCS sniffs from the command-line. Also see: #146

The text in the readme was a bit dated.
@jrfnl jrfnl added this to the 1.3.0 milestone Jul 25, 2019
@IreneStr IreneStr self-assigned this Jul 31, 2019
Copy link
Contributor

@IreneStr IreneStr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR 🚧 Some minor comments

README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@IreneStr IreneStr assigned jrfnl and unassigned IreneStr Jul 31, 2019
... based on PR review.
@jrfnl
Copy link
Collaborator Author

jrfnl commented Jul 31, 2019

@IreneStr Thanks for the review. I've added an additional commit with the changes, including some further textual improvements.

Please feel free to squash the commits on merge.

@jrfnl jrfnl assigned IreneStr and unassigned jrfnl Jul 31, 2019
@IreneStr
Copy link
Contributor

Second CR 👍

@IreneStr IreneStr merged commit 3609178 into develop Jul 31, 2019
@IreneStr IreneStr deleted the JRF/update-readme branch July 31, 2019 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants