YoastCS: always flag comma spacing in function calls #378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `Universal.WhiteSpace.CommaSpacing` has modular error codes to allow for preventing duplicate error messages about the same issue from different sniffs. WordPressCS excludes the "function call" related error codes from the sniff to prevent an overlap with the `Generic.Functions.FunctionCallArgumentSpacing` sniff, but this doesn't play nice with a code base using short arrays as the spacing after commas in a short array being passed as a parameter in a function call will then also be skipped. This change prevents this issue and ensures that the spacing around those commas will be checked correctly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
Universal.WhiteSpace.CommaSpacinghas modular error codes to allow for preventing duplicate error messages about the same issue from different sniffs.WordPressCS excludes the "function call" related error codes from the sniff to prevent an overlap with the
Generic.Functions.FunctionCallArgumentSpacingsniff, but this doesn't play nice with a code base using short arrays as the spacing after commas in a short array being passed as a parameter in a function call will then also be skipped.This change prevents this issue and ensures that the spacing around those commas will be checked correctly.