YoastCS: check YoastCS native files for codestyle compliance #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moorscode
suggested changes
Dec 19, 2017
| @@ -42,12 +42,24 @@ before_install: | |||
| - export XMLLINT_INDENT=" " | |||
| - export PHPCS_DIR=/tmp/phpcs | |||
| - export PHPCS_BIN=$PHPCS_DIR/bin/phpcs | |||
| - export WPCS_DIR=/tmp/wpcs | |||
| - export PHPCOMPAT_DIR=/tmp/phpcompatibility | |||
| - mkdir -p $PHPCS_DIR && git clone --depth 1 https://github.com/squizlabs/PHP_CodeSniffer.git -b $PHPCS_BRANCH $PHPCS_DIR | |||
| - $PHPCS_BIN --config-set installed_paths $(pwd) | |||
There was a problem hiding this comment.
Is this line still needed? It seems like the configuration is set twice when $SNIFF is configured.
When not sniffing, this does not need to be cloned or configured right?
There was a problem hiding this comment.
When not sniffing, the unit tests are run using the PHPCS unit test framework. For that to only test the YoastCS native sniffs, the YoastCS standard needs to be registered, so yes, this is still needed, though it could possibly be combined with the version of it below with an if/then/else syntax. You know how to do those in Travis scripts ?
.phpcs.xml.dist
Outdated
| <description>The Coding standard for the Yoast Coding Standard itself.</description> | ||
|
|
||
| <!-- Scan all files. --> | ||
| <file>.</file> |
Includes addition of a fully documented `.phpcs.xml.dist` file specifically for YoastCS itself.
jrfnl
force-pushed
the
JRF/add-checking-for-codestyle
branch
from
1ac787f
to
f15ba0b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes addition of a fully documented
.phpcs.xml.distfile specifically for YoastCS itself and fixes to the IfElseDeclaration sniff to comply.