Update for new releases PHPCompatibility and WPCS #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Committing the `composer.lock` file for libraries is not necessary as it will be ignored anyway by the consumers of the package. Also, as this library is supposed to support various versions of PHPCS and in the future possibly various version of WPCS, it is actually a bad idea to lock the versions as this makes testing against different PHPCS/WPCS combinations more involved.
This simplifies the `install` script, especially when in the future various version of WPCS would be supported too. Includes caching of the Packagist downloads.
jrfnl
force-pushed
the
JRF/update-for-new-releases-phpcompatibility-wpcs
branch
2 times, most recently
from
51298cb
to
673eac9
Compare
PHPCompatibility has been moved to a dedicated GitHub organisation account and has released version 8.2.0. A `PHPCompatibilityWP` ruleset is now also available in a separate repo which already excludes all back-fills/poly-fills which WP provides. This ruleset should from now on be used to test the plugins. For testing this repository, the "normal" PHPCompatibility ruleset should still be used as the code from this repo is not run within the context of WP, but in the context of PHPCS. For more details, see the [release notes of the PHPCompatibility 8.2.0 release](https://github.com/PHPCompatibility/PHPCompatibility/releases/tag/8.2.0).
jrfnl
force-pushed
the
JRF/update-for-new-releases-phpcompatibility-wpcs
branch
from
673eac9
to
9833b96
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the composer.lock file
Committing the
composer.lockfile for libraries is not necessary as it will be ignored anyway by the consumers of the package.Also, as this library is supposed to support various versions of PHPCS and in the future possibly various version of WPCS, it is actually a bad idea to lock the versions as this makes testing against different PHPCS/WPCS combinations more involved.
Travis: install dependencies via Composer instead of via git cloning
This simplifies the
installscript, especially when in the future various version of WPCS would be supported too.Start using PHPCompatibilityWP
PHPCompatibility has been moved to a dedicated GitHub organisation account and has released version 8.2.0.
A
PHPCompatibilityWPruleset is now also available in a separate repo which already excludes all back-fills/poly-fills which WP provides.This ruleset should from now on be used to test the plugins.
For testing this repository, the "normal" PHPCompatibility ruleset should still be used as the code from this repo is not run within the context of WP, but in the context of PHPCS.
For more details, see the release notes of the PHPCompatibility 8.2.0 release.
Upgrade to WPCS 1.0.0
No changes needed in the ruleset.