Fix reading of start_paused localStorage #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slokhorst
changed the title
|
Thanks for this. I really want to get chrome.storage implemented and this will have to do until I have time to do that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Booleans are stored in localStorage as strings. And since
Boolean("false") == true, this would causelocalStorage.start_pausedto be misinterpreted.If we implement #22 this would no longer be an issue, as chrome.strorage can store booleans (and other objects). Another option would be to wrap localStorage with
JSON.stringify()on store andJSON.parse()on load. I'm not sure what the other (dis)advantages of chrome.storage are.That would allow us to remove all these ugly and error-prone
=== 'true'comparisons.