feat: add computer extension attributes resources and data sources #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Very nice @forevanyeung!! Feel free to make the PR ready for review when you think it's ready |
|
finished up the docs and a minor bug. ready for review, thanks! |
Yohan460
approved these changes
Apr 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
This PR includes a new enhancement to support Jamf computer extension attributes in the terraform provider. It utilizes new functionality added to the Jamf client in Yohan460/go-jamf-api#10.
The
text_fieldschema is meant to be empty since there are no configurable options, however since Terraform does not see an empty TypeSet as existing, I put in a computed elementinput_typethat is unused. Let me know if there is a better way to do this.Thanks