Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace all this.Cc/this.Ci with Cc/Ci #1

Closed
wants to merge 1 commit into from

Conversation

ath0mas
Copy link

@ath0mas ath0mas commented Dec 19, 2015

No description provided.

@ath0mas
Copy link
Author

ath0mas commented Dec 19, 2015

Seems not that good
Cc is not defined - utility.js:53:0 opening Preferences
ReferenceError: Cc is not defined - utility.js:47:9 changing Application mode

@YoruNoHikage
Copy link
Owner

I don't know what makes Cc defined or not.
Try this at the top :
const { classes: Cc, interfaces: Ci, utils: Cu } = Components;

@ath0mas
Copy link
Author

ath0mas commented Dec 19, 2015

Same for me ^^
Cc and Ci are defined at the end of EchofonCommon object in utility.js...
Are you able to debug/add breakpoints through Browser Toolbox? It does not stop on breakpoint for echofon for me :(

I'll check each use of Cc/Ci/this.Cc/this.Ci by hand later this week-end

@YoruNoHikage
Copy link
Owner

It doesn't work either, I just use some console.log. :/

@ath0mas ath0mas closed this Dec 20, 2015
@ath0mas ath0mas deleted the YoruNoHikage-fix branch December 20, 2015 18:20
@ath0mas
Copy link
Author

ath0mas commented Dec 20, 2015

I mistakenly deleted my branch, so PR was closed
No matter. Branch restored. I'll check uses and give feedback later ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants