Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pandas version #576

Closed
wants to merge 1 commit into from
Closed

pandas version #576

wants to merge 1 commit into from

Conversation

adamgayoso
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Feb 4, 2020

Codecov Report

Merging #576 into master will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #576      +/-   ##
==========================================
- Coverage   88.51%   88.48%   -0.03%     
==========================================
  Files          35       35              
  Lines        4509     4509              
==========================================
- Hits         3991     3990       -1     
- Misses        518      519       +1
Impacted Files Coverage Δ
scvi/inference/autotune.py 75.57% <0%> (-0.22%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e79fccb...7401fdb. Read the comment docs.

@romain-lopez
Copy link
Member

That does not sound like the right fix ? Let's not merge that. Is there a bug in 1.0 ? It sounds more like we should fix the code instead. If there is a real reason to reject this version then we should use != 1.0

@adamgayoso adamgayoso closed this Feb 7, 2020
@adamgayoso adamgayoso deleted the pandas branch February 7, 2020 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants