Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace deprecated KeyArray with Array #135

Merged
merged 1 commit into from Feb 8, 2024
Merged

Replace deprecated KeyArray with Array #135

merged 1 commit into from Feb 8, 2024

Conversation

martinkim0
Copy link
Member

JAX 0.4.24 removed random.KeyArray. According to the deprecation warning, it can be replaced with jax.Array:

DeprecationWarning: jax.random.KeyArray is deprecated. Use jax.Array for annotations, and jax.dtypes.issubdtype(arr.dtype, jax.dtypes.prng_key) for runtime detection of typed prng keys (i.e. keys created with jax.random.key).

Copy link

codecov bot commented Feb 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (620f109) 91.00% compared to head (c5c0b0a) 91.01%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #135   +/-   ##
=======================================
  Coverage   91.00%   91.01%           
=======================================
  Files          25       25           
  Lines         956      957    +1     
=======================================
+ Hits          870      871    +1     
  Misses         86       86           
Files Coverage Δ
src/scib_metrics/_types.py 100.00% <100.00%> (ø)
src/scib_metrics/utils/_kmeans.py 93.06% <100.00%> (+0.06%) ⬆️
src/scib_metrics/utils/_utils.py 60.60% <100.00%> (ø)

@martinkim0 martinkim0 merged commit 6cf394e into main Feb 8, 2024
7 checks passed
@martinkim0 martinkim0 deleted the update-jax branch February 8, 2024 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant