form lesson #1
Merged
form lesson #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
exercise.html
Outdated
| </div> | ||
| <div> | ||
| 性別: <label> | ||
| <input type="radio" required name="sex">男性 |
There was a problem hiding this comment.
value属性を使って選択したのが 男性 なのか 女性 なのかわかるようにしてください。
送信ボタンを押した後の値
期待する値
exercise.html
Outdated
| <p>以下のフォームを埋めて下さい。（※は必須項目）</p> | ||
| <form action=""> | ||
| <div> | ||
| <label>※ユーザー名: <input type="text" required></label> |
There was a problem hiding this comment.
いくつか name属性が使われていないので、送信ボタンを押した後に、値が取得できない状態となっています。
現状取得している内容
期待する取得内容
|
コメントしたのでご確認お願いしますmm |
| </label> | ||
| <label> | ||
| <input type="radio" required name="sex">女性 | ||
| <input type="radio" required name="sex" value="woman">女性 |
There was a problem hiding this comment.
細かいですが、性別を表す英単語を使う場合は、それぞれ対応したものを使うほうが良いかと思います。
- man と woman
- male と female
exercise.html
Outdated
| </label> | ||
| </div> | ||
| <div> | ||
| <p>備考欄:</p> <textarea cols="30" rows="10"></textarea> |
There was a problem hiding this comment.
textareaにname属性が無いため送信ボタンを押しても値が取得できない状態になっています。
textareaに文字を入力してもURLに出てこない
↓
|
2点コメントしたのでご確認お願いしますmm |
|
👍 OKです^^ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fromはあまり触ってこなかったので、課題やりました！
添削お願い致します！