Fix Equal Temperament variation when voice is being imported. #136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the voice is imported, the 440Hz is not used, the frequency is taken from the importing voice. However, it should still be possible to use the Eq.T. wheel if 440Hz is enabled in both voices. With this fix it is even possible to use Eq.T. without 440Hz enabled, if the importing voice has it disabled. The effect is then added to the existing 1x equal temperament from the importing voice. Signed-off-by: Kristian Amlie <kristian@amlie.name>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the voice is imported, the 440Hz is not used, the frequency is
taken from the importing voice. However, it should still be possible
to use the Eq.T. wheel if 440Hz is enabled in both voices.
With this fix it is even possible to use Eq.T. without 440Hz enabled,
if the importing voice has it disabled. The effect is then added to
the existing 1x equal temperament from the importing voice.
Signed-off-by: Kristian Amlie kristian@amlie.name