Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ecp5: Improve constraint-related error handling #243

Merged
merged 3 commits into from
Feb 28, 2019
Merged

ecp5: Improve constraint-related error handling #243

merged 3 commits into from
Feb 28, 2019

Conversation

daveshah1
Copy link
Contributor

  • Better errors (with line numbers) and fewer assertion failures in the LPF parser
  • Remove the warning for unmatched constraints; add an error if an LPF file is specified but some IO are unconstrained, with --lpf-allow-unconstrained to override (this is identical to the current iCE40 situation)

@daveshah1 daveshah1 mentioned this pull request Feb 27, 2019
Closed
mmicko
mmicko approved these changes Feb 28, 2019
View reviewed changes
Copy link
Member

@mmicko mmicko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks for taking care of this

@daveshah1 daveshah1 merged commit 0279f63 into master Feb 28, 2019
@eddiehung eddiehung added todo-ecp5-regression Note to add this to ecp5 regressions and removed todo-ecp5-regression Note to add this to ecp5 regressions labels Feb 28, 2019
@daveshah1 daveshah1 deleted the ecp5lpf branch March 1, 2019 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmicko mmicko mmicko approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@daveshah1 @mmicko @eddiehung @gatecat