cxxrtl: Fix value::ctlz

YosysHQ · Dec 13, 2023 · d7cb698 · d7cb698
1 parent ded63be
commit d7cb698
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 2 deletions.
diff --git a/backends/cxxrtl/runtime/cxxrtl/cxxrtl.h b/backends/cxxrtl/runtime/cxxrtl/cxxrtl.h
@@ -511,7 +511,8 @@ struct value : public expr_base<value<Bits>> {
 		for (size_t n = 0; n < chunks; n++) {
 			chunk::type x = data[chunks - 1 - n];
 			// First add to `count` as if the chunk is zero
-			count += (n == 0 ? Bits % chunk::bits : chunk::bits);
+			constexpr size_t msb_chunk_bits = Bits % chunk::bits != 0 ? Bits % chunk::bits : chunk::bits;
+			count += (n == 0 ? msb_chunk_bits : chunk::bits);
 			// If the chunk isn't zero, correct the `count` value and return
 			if (x != 0) {
 				for (; x != 0; count--)

diff --git a/tests/cxxrtl/test_value.cc b/tests/cxxrtl/test_value.cc
@@ -36,4 +36,10 @@ int main()
         cxxrtl::value<64> c = a.sshr(b);
         assert(c.get<uint64_t>() == 0xffffffff8abcdef1u);
     }
-}
+
+    {
+        // ctlz should work with Bits that are a multiple of chunk size
+        cxxrtl::value<32> a(0x00040000u);
+        assert(a.ctlz() == 13);
+    }
+}