Python-api tests #1027
Closed
Python-api tests #1027
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
May 22, 2019 18:01
Note: There are tests marked as skip.
Can now traverse connections_ python3 -m unittest discover Ran 4 tests in 0.014s OK (skipped=2)
Don’t bring nullptr checks to Python side. Use is_wire() for SigBits. Tried to ifdef code behind #ifdef WITH_PYTHON, it doesn’t work. python3 -m unittest test_json test_bindings Ran 6 tests in 0.029s OK (skipped=2)
|
Let's put this PR on hold until I have explored pybind11. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My motivation: Tests would work also as a reference how to use Yosys with the api.
Here is some initial work for testing python-api. One contains simple sanity tests. Another test is implementation of JSON writer by using python-api. Currently JSON writer is wip state but can make output that matches with fixed reference JSON. Goal is to make it match with Yosys JSON output.
There are lines marked with TODO: = need some attention like one already mentioned #1020 and #995
I tried to add C code behind #ifdef WITH_PYTHON but somehow it's not working. Any help is appreciated.
Found that backticks mentioned #1029 disturbed compile flags and WITH_PYHTON. Proposed fix for this in PR #1030