Removing cells_sim from GoWin bram techmap #1685
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dh73
referenced
this pull request
Feb 6, 2020
|
Thanks Diego! This was something I spotted working on #1682 . Also, can you re-do your branch with just the 931a68f commit and not the previous two which seem to be no-ops? |
|
Yeah, one of these two commits was too old. Sorry for that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Answering @eddiehung reviews request, I'm fixing one of the comments:
f9272fc#r37144384
the other one: f9272fc#r37144371
Makes perfect sense to remove
run("techmap -map +/techmap.v");since is irrelevant, butfinesynthesis seems to be replaced formap_fframandmap_gatesin current head, so these lines does not exists in master anymore.