Secuirty/sql injection vector #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e_template can exist
…ed variable name in db statements
yancyribbens
force-pushed
the
secuirty/sql-injection-vector
branch
from
36be9a4
to
0b4b4ec
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR sanitizes the input to
delete_recordshere. Thisdelete_recordscall is used such that if abadge_templatewas already selected, and next, a different badge_template is selected, the associated table will calldelete_recordson the previous and insert the most recent. The superfluous code was removed which checked if it existed before deleting and instead simplified to just calldelete_recordsas suggested in #8 regardless of if a record already exists and the tablename is no longer stored in a variable here. Lastly, the ultimate goal is to not allow more than onecourse_idto exist currently, and so, a constraint was added here to further enforce the expected behavior.