Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade stylelint to 12.0.0 #46

Merged
merged 1 commit into from
Dec 3, 2019
Merged

Upgrade stylelint to 12.0.0 #46

merged 1 commit into from
Dec 3, 2019

Conversation

ybiquitous
Copy link
Contributor

@YozhikM
Copy link
Owner

YozhikM commented Dec 3, 2019

LGTM

@YozhikM YozhikM marked this pull request as ready for review December 3, 2019 12:09
@YozhikM YozhikM merged commit bfd19b5 into YozhikM:master Dec 3, 2019
@ybiquitous
Copy link
Contributor Author

yarn install is run on Travis CI, but the current yarn.lock is outdated. See below.

stylelint-a11y/yarn.lock

Lines 5645 to 5646 in 1c522f6

stylelint@^10.0.1:
version "10.0.1"

I think better to remove yarn.lock and package-lock.json.

@ybiquitous ybiquitous deleted the stylelint-v12 branch December 3, 2019 12:10
@ybiquitous
Copy link
Contributor Author

@YozhikM Thank you for your review and quick merge! What do you think about #46 (comment)?

@ybiquitous
Copy link
Contributor Author

Another option:

  • To remove package-lock.json and keep yarn.lock up-to-date.

@YozhikM
Copy link
Owner

YozhikM commented Dec 3, 2019

We can try to remove package-lock.json and leave yarn.lock. Of course you need to update it

@ybiquitous
Copy link
Contributor Author

Thanks. If you feel hard to keep yarn.lock up-to-date, I recommend any lockfiles and open #47 as PoC.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

stylelint 12.x as peer dependency
2 participants