-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Renamed Vset.modules to Vset.vfuncs and Vset.out to Vset.fitted_vfuncs #41
Conversation
ssaxena00
commented
Feb 2, 2022
•
edited
Loading
edited
- Still have to change docs (how to do this?)
- Can still change:
- ‘apply_modules’ -> ‘apply_vfuncs’ (in utils.py),
- ‘modules’ -> ‘funcs’ (in vset.py)
- 'module_keys' -> 'func_keys' (in vset.py)
@@ -71,7 +71,7 @@ def __init__(self, name: str, modules, module_keys: list = None, | |||
if not self._async and np.any([isinstance(mod, AsyncModule) for mod in modules]): | |||
self._async = True | |||
if isinstance(modules, dict): | |||
self.modules = modules | |||
self.vfuncs = modules |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's also change the init argument names from modules
and module_keys
to funcs
and func_keys
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should I also change apply_modules
-> apply_vfuncs
(in utils.py)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, please. Let's replace all usage of module
with vfunc
.
Discovered errors in p_check.ipynb:
|
Discovered errors in
|
Discovered errors in
|
Causing error in |
Discovered error in
|
@ssaxena00 We can delete that notebook. Also feel free to replace |