Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renamed Vset.modules to Vset.vfuncs and Vset.out to Vset.fitted_vfuncs #41

Closed
wants to merge 2 commits into from

Conversation

ssaxena00
Copy link
Contributor

@ssaxena00 ssaxena00 commented Feb 2, 2022

  • Still have to change docs (how to do this?)
  • Can still change:
    • ‘apply_modules’ -> ‘apply_vfuncs’ (in utils.py),
    • ‘modules’ -> ‘funcs’ (in vset.py)
    • 'module_keys' -> 'func_keys' (in vset.py)

@@ -71,7 +71,7 @@ def __init__(self, name: str, modules, module_keys: list = None,
if not self._async and np.any([isinstance(mod, AsyncModule) for mod in modules]):
self._async = True
if isinstance(modules, dict):
self.modules = modules
self.vfuncs = modules
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's also change the init argument names from modules and module_keys to funcs and func_keys.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should I also change apply_modules -> apply_vfuncs (in utils.py)?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, please. Let's replace all usage of module with vfunc.

@ssaxena00
Copy link
Contributor Author

Discovered errors in p_check.ipynb:

  • removed compute_Interval ?
  • in executing filtered_rf_set.fit(X_train_clean, y_train):
    • got TypeError: float() argument must be a string or a number, not 'dict'

@jpdunc23 jpdunc23 marked this pull request as draft February 2, 2022 19:50
@ssaxena00
Copy link
Contributor Author

Discovered errors in build_Vset.ipynb:

  • call to build_vset is not resulting in correct .vfuncs attribute
    • length is 1 and vfunc looks like:
      RandomForestRegressor(criterion='absolute_error', n_estimators={'max_features': ['sqrt', 'log2'], 'min_samples_split': [2, 10], 'n_estimators': [100, 200, 300]})

@ssaxena00
Copy link
Contributor Author

Discovered errors in 03_computer_vision_dnn:

  • while executing modeling_set.fit(train_data):
    • got TypeError: train() got multiple values for argument 'loss_fn'

@ssaxena00
Copy link
Contributor Author

Causing error in 04_feat_importance_stability.ipynb because build_vset not setting .vfuncs attribute correctly

@ssaxena00
Copy link
Contributor Author

Discovered error in mlflow_logging_hardcoded:

  • while executing train(C, min_samples_leaf:
    • got KeyError: ('X_test', (X_train, X_train, LR, 'X_test'), 'Acc')

@jpdunc23
Copy link
Collaborator

jpdunc23 commented Feb 3, 2022

Discovered error in mlflow_logging_hardcoded:

  • while executing train(C, min_samples_leaf:

    • got KeyError: ('X_test', (X_train, X_train, LR, 'X_test'), 'Acc')

@ssaxena00 We can delete that notebook. Also feel free to replace compute_interval with perturbation_stats and let me know if usage of the latter isn't clear.

@ssaxena00 ssaxena00 closed this Feb 8, 2022
@ssaxena00 ssaxena00 deleted the sahil_starter branch February 8, 2022 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants