Refactor layoutDaylight part 2 #169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Cache frequent and expensive lookup such as `df$x` - Exclude nodes in vectorized manner before for-loop - Now it runs >2x faster with exactly the same results
|
thanks, you can add your name in the author list as contributor. https://github.com/GuangchuangYu/ggtree/edit/master/DESCRIPTION. |
heavywatal
added a commit
to heavywatal/ggtree
that referenced
this pull request
Mar 5, 2018
@heavywatal refactored layoutDaylight in YuLab-SMU#165 and YuLab-SMU#169
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for merging the previous PR #165 . This is a sequel of it.
df$x