Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make YubiKeyDeviceListener resettable #89

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Make YubiKeyDeviceListener resettable #89

wants to merge 1 commit into from
+82 −56

Commits on Apr 3, 2024

  1. Make YubiKeyDeviceListener resettable 

    Currently, YubiKeyDeviceListener only exposes a singleton instance with no
way for a consumer to reset it once it is started. The constructor is private, so
the consumer has no option to use a private instance.

This adds the ability for the consumer to reset the lazy-initialized singleton so that
the listen thread doesn't stick around.

Also, even though this class implemented IDisposable, most things that need to be
in the Dispose method weren't there, including a way to stop the thread.

The listen thread is now replaced by an asynchronous task that doesn't consume
a system thread while it's not working.
    @jamiehankins
    jamiehankins committed Apr 3, 2024
    Configuration menu
    Copy the full SHA
    ce5ddc1 View commit details
    Browse the repository at this point in the history