Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support authenticatorAttachment in PublicKeyCredential #250

Merged
merged 4 commits into from
Dec 16, 2022
Merged

Support authenticatorAttachment in PublicKeyCredential #250

merged 4 commits into from
Dec 16, 2022

Conversation

luisgoncalves
Copy link
Contributor

@luisgoncalves luisgoncalves commented Dec 16, 2022 •
edited by emlun
Loading

Fixes #249.

@emlun emlun self-requested a review December 16, 2022 12:10
@luisgoncalves
Copy link
Contributor Author

Failing at com.yubico.webauthn.data.JsonIoSpec > The class PublicKeyCredential allows and ignores an authenticatorAttachment attribute. I'll check.

@emlun
Copy link
Member

emlun commented Dec 16, 2022

Thanks but no need, I've already pushed a fix. 🙂

emlun
emlun approved these changes Dec 16, 2022
View reviewed changes
Copy link
Member

@emlun emlun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks really good, thanks!

Would you like to be credited in the release notes? And if so, by GitHub username or real name?

@luisgoncalves
Copy link
Contributor Author

Thanks for the help, and for the library.

Sure, why not :) use the GH username.

@emlun emlun merged commit 35c983d into Yubico:main Dec 16, 2022
@luisgoncalves luisgoncalves deleted the feature/credential-authenticator-attachment branch December 16, 2022 16:28
emlun added a commit that referenced this pull request Jan 11, 2023
@emlun
Release 2.3.0
424520f 
New features:

- (Experimental) Added `authenticatorAttachment` property to response
  objects:
  - NOTE: Experimental features may receive breaking changes without a
    major version increase.
  - Added method `getAuthenticatorAttachment()` to
    `PublicKeyCredential` and corresponding builder method
    `authenticatorAttachment(AuthenticatorAttachment)`.
  - Added method `getAuthenticatorAttachment()` to
    `RegistrationResult` and `AssertionResult`, which echo
    `getAuthenticatorAttachment()` from the corresponding
    `PublicKeyCredential`.
  - Thanks to GitHub user luisgoncalves for the contribution, see
    #250

Other:

- Fixed the README description of SemVer exceptions: `@Deprecated`
  features are still part of the public API unless they also have an
  `EXPERIMENTAL:` tag in JavaDoc.
- Brought `com.yubico.webauthn` package JavaDoc up to date with new
  library features.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emlun emlun emlun approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support for PublicKeyCredential.authenticatorAttachment
2 participants
@luisgoncalves @emlun