Add Android safety-net attestation statement offline verification. #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for the contribution! I'll get back to you when I've had some time to look at this. |
Pull Request Test Coverage Report for Build 106
💛 - Coveralls |
|
Thank you for contributing this! I ended up restructuring the code quite a bit, but this is now merged into master and will be included in the next release. Please let us know if you have any problems with it. |
emlun
added a commit
that referenced
this pull request
Jan 21, 2019
Possibly breaking changes:
- User Presence (UP) is now always required by the spec, not only when
UV is not required; implementation updated to reflect this.
New features:
- Added support for `android-safetynet` attestation statement format
- Thanks to Ren Lin for the contribution, see
#5
- Implementation updated to reflect Proposed Recommendation version of
the spec, released 2019-01-17
Bug fixes:
- Fixed validation of zero-valued assertion signature counter
- Previously, a zero-valued assertion signature counter was always
regarded as valid. Now, it is only considered valid if the stored
signature counter is also zero.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.