Add PIV cert generation wizard #88
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dagheyman
suggested changes
Nov 16, 2018
There was a problem hiding this comment.
Cool. Some comments:
I think the flow should be restructured a bit, my suggestion is this:
1. Select output format
2. Select algorithm
3. Select subject name
4. IF self-signed: Select expiry date
5. Confirmation view with finish button
6. IF certificate already in slot: Overwrite-confirmation-popup
7. PIN/MGM key popup.
8. IF CSR: Save output file dialog
9. Generic success popup
- Expiration date: should have a default value of 1 year
- Expiration date: don't allow dates before today
- Calendar widget should be aligned to the right of the input field
- Algorithm: ECCP-384 is not supported on NEO
| import QtQuick.Controls 2.2 | ||
| import QtQuick.Layouts 1.3 | ||
| import QtQuick.Controls.Material 2.2 | ||
| import Qt.labs.calendar 1.0 |
There was a problem hiding this comment.
The calendar qml module needs to be added as a dependency in debian/control and doc/development
| FileDialog { | ||
| id: selectCsrOutputDialog | ||
| title: "Please choose a destination" | ||
| defaultSuffix: "csr" |
There was a problem hiding this comment.
Default suffix was added in Qt 5.10 unfortunately.
http://doc.qt.io/qt-5/qml-qtquick-dialogs-filedialog.html#defaultSuffix-prop
|
Calendar: Drop WeekNumber and DayOfWeek, hard code en_US locale |
piv: small layout fixes for wizard
This is implicit now that the RadioButtons share the same parent.
Otherwise it's too narrow (on my machine) and cuts the content off early...
Polish cert wizard layout
This reverts commit 292f881.
piv: update CSR save dialog
piv: use username as default subject name
calendar: don't allow flickering and flatten buttons
Put NextButton icon on the right
dagheyman
approved these changes
Nov 23, 2018
|
🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.