Merge pull request #308 from halfvim/flashlight

Fix bug of flashlight button disappearing when flip camera twice
Yummypets · Apr 28, 2019 · 8fd8931 · 8fd8931
2 parents 6d457ec + f7cea7d
commit 8fd8931
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 4 deletions.
diff --git a/Source/Pages/Photo/YPCameraVC.swift b/Source/Pages/Photo/YPCameraVC.swift
@@ -83,8 +83,7 @@ public class YPCameraVC: UIViewController, UIGestureRecognizerDelegate, YPPermis
     @objc
     func flipButtonTapped() {
         doAfterPermissionCheck { [weak self] in
-            self?.photoCapture.flipCamera()
-            DispatchQueue.main.async {
+            self?.photoCapture.flipCamera {
                 self?.refreshFlashButton()
             }
         }

diff --git a/Source/Pages/Photo/YPPhotoCapture.swift b/Source/Pages/Photo/YPPhotoCapture.swift
@@ -19,7 +19,7 @@ protocol YPPhotoCapture: class {
     func tryToggleFlash()
     var hasFlash: Bool { get }
     var currentFlashMode: YPFlashMode { get }
-    func flipCamera()
+    func flipCamera(completion: @escaping () -> Void)
     func shoot(completion: @escaping (Data) -> Void)
     var videoLayer: AVCaptureVideoPreviewLayer! { get set }
     var device: AVCaptureDevice? { get }

diff --git a/Source/Pages/Photo/YPPhotoCaptureDefaults.swift b/Source/Pages/Photo/YPPhotoCaptureDefaults.swift
@@ -103,9 +103,12 @@ extension YPPhotoCapture {
 
     // MARK: - Flip
 
-    func flipCamera() {
+    func flipCamera(completion: @escaping () -> Void) {
         sessionQueue.async { [weak self] in
             self?.flip()
+            DispatchQueue.main.async {
+                completion()
+            }
         }
     }