Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug of flashlight button disappearing when flip camera twice #308

Merged
merged 2 commits into from
Apr 28, 2019
Merged

Fix bug of flashlight button disappearing when flip camera twice #308

merged 2 commits into from
Apr 28, 2019

Conversation

nrthyrk
Copy link
Contributor

@nrthyrk nrthyrk commented Jan 26, 2019

The PR fixes the flashlight disappearing issue mentioned in #120

@nrthyrk nrthyrk changed the title Fix flashlight button disappears when flip camera twice Fix bug of flashlight button disappearing when flip camera twice Feb 7, 2019
@nrthyrk
Copy link
Contributor Author

nrthyrk commented Feb 7, 2019

Could someone review this PR? @s4cha

@s4cha
Copy link
Member

s4cha commented Apr 28, 2019

@halfvim As described in #120 this was only happening in iPhone 5c, iOS 10.3.3 right ?
I'll have to trust you on that one since I can't test on my side :)
Thank you so much for taking the time to fix this, this is awesome 👍

@s4cha s4cha merged commit 8fd8931 into Yummypets:master Apr 28, 2019
@nrthyrk
Copy link
Contributor Author

nrthyrk commented Apr 28, 2019

This issue occurred to me on iPhone 6, iOS 12. Don't remember the minor version though, already upgraded once or twice.

LucasDang pushed a commit to pukapp/secret-ios-YPImagePicker that referenced this pull request Feb 10, 2022
Fix bug of flashlight button disappearing when flip camera twice
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants