Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to customize folder where to store backups. #46

Open
wants to merge 3 commits into
base: testing
Choose a base branch
from

Conversation

eauchat
Copy link

@eauchat eauchat commented Oct 1, 2021

Now that borg_ynh supports setting up any custom repository, it seems it could be nice if borgserver_ynh does it as well.
This patch is not making the repo fully configurable, but allows to modify the hardcoded ~/backup into ~/<anything>.

I wasn't able to test it unfortunately, having a strange Info: WARNING - usermod: group 'ssh.app' does not exist error and the app fails to install, but I don't see how this could be related to the modifications.
Also I don't know if passing a sub/folder as repository_folder will work or fail.

This is not designed to allow to choose a folder outside of the user's home, as it would be much more tricky to implement. I added to the README a recommendation for people who have this need to simply use mount --bind /backup/path /home/ssh_user/repository_folder.

@eauchat
Copy link
Author

eauchat commented Oct 1, 2021

!testme

@yunohost-bot
Copy link
Contributor

Alrighty!
Test Badge

@alexAubin
Copy link
Member

( LGTM on principle but I don't know about all the little technicalities to check 😅 )

@zamentur
Copy link
Contributor

zamentur commented Dec 2, 2021

I am not sure it's relevant to do that. I mean what's the use case ? What the gain to be able to choose the directory ?

@eauchat
Copy link
Author

eauchat commented Dec 4, 2021

I am not sure it's relevant to do that. I mean what's the use case ? What the gain to be able to choose the directory ?

Apart from the naming flexibility it brings, that some people may appreciate, my personal use case, is to be able to backup multiple different servers into one destination server, without them having to share the same repository, and without having to install multiple time borgserver_ynh thus creating multiple users.
One user, multiple borg repositories. I imagined it was a common use case.

@Salamandar Salamandar force-pushed the testing branch 2 times, most recently from eab7816 to 677a9cc Compare August 12, 2024 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants