Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add config to change settings.DEBUG #18

Closed
wants to merge 1 commit into from
Closed

Add config to change settings.DEBUG #18

wants to merge 1 commit into from

Conversation

jedie
Copy link
Collaborator

@jedie jedie commented May 18, 2022

Problem

  • Description of why you made this PR

Solution

  • And how do you fix that problem

PR Status

  • Code finished and ready to be reviewed/tested
  • The fix/enhancement were manually tested (if applicable)

Automatic tests

Automatic tests can be triggered on https://ci-apps-dev.yunohost.org/ after creating the PR, by commenting "!testme", "!gogogadgetoci" or "By the power of systemd, I invoke The Great App CI to test this Pull Request!". (N.B. : for this to work you need to be a member of the Yunohost-Apps organization)

@jedie jedie force-pushed the config branch 15 times, most recently from d8b59b9 to 2e99a8a Compare May 18, 2022 18:37
@codecov-commenter
Copy link

codecov-commenter commented May 18, 2022

Codecov Report

Merging #18 (2e99a8a) into testing (7f3a3c4) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           testing      #18   +/-   ##
========================================
  Coverage    85.36%   85.36%           
========================================
  Files            5        5           
  Lines          164      164           
========================================
  Hits           140      140           
  Misses          24       24           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7f3a3c4...2e99a8a. Read the comment docs.

@jedie
Copy link
Collaborator Author

jedie commented May 19, 2022

!testme

@yunohost-bot
Copy link
Contributor

Alrighty!
Test Badge

type = "boolean"
yes = "True"
no = "False"
bind = "DJANGO_DEBUG:/opt/yunohost/__APP__/local_settings.py"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The variable in local_settings.py that you want to change is name DEBUG, not DJANGO_DEBUG (DJANGO_DEBUG is your bash var durint install/upgrade operation)

Suggested change
bind = "DJANGO_DEBUG:/opt/yunohost/__APP__/local_settings.py"
bind = "DEBUG:/opt/yunohost/__APP__/local_settings.py"

@jedie
Copy link
Collaborator Author

jedie commented Aug 16, 2022

reworked in #20

@jedie jedie closed this Aug 16, 2022
@jedie jedie deleted the config branch August 16, 2022 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants