Testing #30
Merged
Testing #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…element_ynh into apply-example_ynh
Apply example ynh
|
!testme |
|
🎠 |
|
May the CI gods be with you! |
|
Alrighty! |
tituspijean
approved these changes
Nov 23, 2021
Yes! it's completely gogogagetotranslat! 😅 |
Josue-T
requested changes
Nov 24, 2021
scripts/install
Outdated
| # Set final permission | ||
| ynh_script_progression --message="Protecting directory" | ||
| set_permission | ||
| chmod 750 "$final_path" |
There was a problem hiding this comment.
You don't need the "write" permission for this app.
|
damn, 1.9.5 was suppose to be pushed in a new branch... |
|
!testme |
|
Fingers crossed! |
|
shall we merge? |
|
(Cant approve my own PR but LGTM) |
|
!testme |
|
🌻 |
|
@Josue-T shall we merge? |
|
Merging because the initial changes are 4 months old, all tests are in the green, let's move forward Cheers to everybody involved 🥳 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Solution
PR Status
Automatic tests
Automatic tests can be triggered on https://ci-apps-dev.yunohost.org/ after creating the PR, by commenting "!testme", "!gogogadgetoci" or "By the power of systemd, I invoke The Great App CI to test this Pull Request!". (N.B. : for this to work you need to be a member of the Yunohost-Apps organization)