Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use correct commit hashes for 22.10 and addons. #83

Closed
wants to merge 2 commits into from

Conversation

ndarilek
Copy link

Problem

  • The wrong commit hashes appear to have been used for Friendica 22.10 and its addons.

Solution

  • Use the correct hashes.

PR Status

  • [X ] Code finished and ready to be reviewed/tested
  • The fix/enhancement were manually tested (if applicable)

Automatic tests

Automatic tests can be triggered on https://ci-apps-dev.yunohost.org/ after creating the PR, by commenting "!testme", "!gogogadgetoci" or "By the power of systemd, I invoke The Great App CI to test this Pull Request!". (N.B. : for this to work you need to be a member of the Yunohost-Apps organization)

@tituspijean
Copy link
Member

!testme

@yunohost-bot
Copy link
Contributor

✌️
Test Badge

@tituspijean
Copy link
Member

tituspijean commented Nov 18, 2022

  • Check "upgrade-but actually downgrade" from 22.10~ynh1 to 22.10~ynh2

@tio-trom
Copy link

  • Check "upgrade-but actually downgrade" from 22.10ynh1 to 22.10ynh2

I am starting a conversation with the Frienedica admins and developers here https://social.trom.tf/display/dbc8dc44-1763-7a10-2c3e-2f1003184441 - it seems to be a bad idea to push now a change from the dev version (december) to a stable version (september). It will likely break the installations completely.

The september stable version is kinda buggy anyway and they plan to release another stable in december, maybe wait for that and push an update to that when it is out.

@Quix0r
Copy link

Quix0r commented Nov 20, 2022

Hello all,

a $ git diff upstream/develop..upstream/stable static/dbstructure.config.php tells me that there are changes done to the database tables since last time stable branch was updated. I won't try a downgrade from develop back to stable. The change on file/GIT commit side is trivial: $ git checkout stable but the following needed changes (as your database tables have changed during the upgrade) can be a really bad nightmare.

So you only have 2 safe options left: Remain on develop or restore an old backup before the upgrade to develop code.

@tio-trom
Copy link

So, Friendica's developers plan to release another stable in december. Please for now leave this package as it is, with the development branch, and update in december to the stable one once it is released, so that you upgrade from dev to stable in a chronological order. Else if you try to now update this package with an older release (the stable branch) compared to the one is currently using, then those who upgraded their ynh friendica and update again, will have their instances nuked basically, from what I understand, and no easy way (or any way) to fix it.

In essence do not update from a newere version of friendica to an older one.

@alexAubin alexAubin deleted the branch YunoHost-Apps:testing December 24, 2022 12:41
@alexAubin alexAubin closed this Dec 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants