Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated to the proper 2022.12 stable commits #89

Merged
merged 2 commits into from Dec 23, 2022

Conversation

tio-trom
Copy link

@tio-trom tio-trom commented Dec 21, 2022

Problem

The latest commit pushed to the main ynh branch was again a dev commit and this will again break all friendica installs.

Solution

Add the proper commits that come from the stable branch, this one https://github.com/friendica/friendica/commits/stable

PR Status

  • Code finished and ready to be reviewed/tested
  • The fix/enhancement were manually tested (if applicable)

Automatic tests

Automatic tests can be triggered on https://ci-apps-dev.yunohost.org/ after creating the PR, by commenting "!testme", "!gogogadgetoci" or "By the power of systemd, I invoke The Great App CI to test this Pull Request!". (N.B. : for this to work you need to be a member of the Yunohost-Apps organization)

@alexAubin
Copy link
Member

!testme

@tio-trom tio-trom changed the title Updated to the proper stable commits Updated to the proper 2022.12 stable commits Dec 21, 2022
@alexAubin
Copy link
Member

!testme

@yunohost-bot
Copy link
Contributor

May the CI gods be with you!
Test Badge

@ericgaspar ericgaspar changed the base branch from master to testing December 22, 2022 13:03
@tituspijean
Copy link
Member

Do we need to bump the package version or will it break everything?

@tio-trom
Copy link
Author

Do we need to bump the package version or will it break everything?

So the latest YNH versioning is 2022.12~ynh1 but points to a newer dev versio. If anyone is using that then it is better to let them use that rather than see another update that in fact downgrades it. Therefore I suggest no bumping of the package version. Let those like me, who did not upgrade already, upgrade to the proper stable version. And the rest are still ok but using a dev version.

@tituspijean tituspijean merged commit 6d60ed0 into YunoHost-Apps:testing Dec 23, 2022
@tio-trom
Copy link
Author

I updated my personal instance. All worked. Took a while to update but we have around 1k users. Full log here https://paste.trom.tf/utakapigay.sql

@tio-trom
Copy link
Author

I suggest to merge into main.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants