Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use released 0.17 #37

Closed
wants to merge 7 commits into from
Closed

Use released 0.17 #37

wants to merge 7 commits into from

Conversation

rushsteve1
Copy link

Bumped up to the released 0.17
Also turned on LDAP. I think I got the settings right but please correct me if I didn't.

Feedback welcome! There is likely some issues with the upgrade to 0.17. but LDAP support is worth it.

Jibec and others added 5 commits June 28, 2018 22:43
upgrade to 0.16.3
Bumped up to the released 0.17
Also turned on LDAP. I think I got the settings right.
@rushsteve1 rushsteve1 mentioned this pull request Oct 8, 2018
@agateblue
Copy link

Don't forget there is a script to run for this upgrade: https://docs.funkwhale.audio/upgrading/0.17.html#upgrade-instructions

@rushsteve1
Copy link
Author

Looks like the script was already added to the upgrade file by commit 331300c

@agateblue
Copy link

Awesome, I missed that!

Added services to dashboard and minor LDAP tweak.
@Jibec
Copy link
Contributor

Jibec commented Oct 20, 2018

thanks for your help, I'm afraid you LDAP connection didn't work, it is now fixed with this commit: 3e44180

@Jibec Jibec closed this Oct 20, 2018
@anmol26s
Copy link

Great going to test it.
But Ldap without fail2ban or 2 factor authentication is risky.

@rushsteve1
Copy link
Author

@anmol26s YunoHost itself runs Fail2Ban

@rushsteve1 rushsteve1 deleted the testing branch October 25, 2018 15:30
@anmol26s
Copy link

Yes but it needs to be integrated to the apps.

@Jibec
Copy link
Contributor

Jibec commented Oct 25, 2018 via email

@anmol26s
Copy link

I did it for shaarli app :
This is the helper
https://github.com/YunoHost-Apps/shaarli_ynh/blob/testing/scripts/_common.sh#L16-L78

Fail2ban checks logs for failed attempts and block rules have to be set.Maybe @EliotBerriot can create separate log file for the authentication.
Command :
https://github.com/YunoHost-Apps/shaarli_ynh/blob/testing/scripts/install#L136

@Jibec Jibec mentioned this pull request Oct 27, 2018
@Jibec
Copy link
Contributor

Jibec commented Oct 27, 2018

OK, but please don't continue the conversation here, it should continue in this issue: #47

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants