Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing improve garage package #5

Merged
merged 19 commits into from
Apr 26, 2023
Merged

Testing improve garage package #5

merged 19 commits into from
Apr 26, 2023

Conversation

oiseauroch
Copy link
Collaborator

No description provided.

@oiseauroch
Copy link
Collaborator Author

!testme

@yunohost-bot
Copy link
Contributor

😜
Test Badge

@oiseauroch
Copy link
Collaborator Author

!testme

@yunohost-bot
Copy link
Contributor

✌️
Test Badge

@oiseauroch
Copy link
Collaborator Author

try to fix #4 . @alexAubin how should I remove the custom nginx conf when removing the app ?

@ericgaspar
Copy link
Member

!testme

@yunohost-bot
Copy link
Contributor

😜
Test Badge

#=================================================
ynh_script_progression --message="adding regen-conf hook..." --weight=1

ynh_add_config --template="../sources/hooks/conf_regen/98-nginx_garage" --destination="/usr/share/yunohost/hooks/conf_regen/98-nginx_$app"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It sounds like you're missing a yunohost tools regen-conf nginx here ?

@alexAubin
Copy link
Member

@oiseauroch

try to fix #4 . @alexAubin how should I remove the custom nginx conf when removing the app ?

(cf also #4 (comment) )

I guess you found out since then that the hook should be named XX-nginx_$app, which is a very poorly documented (or probably undocumented..) bit of logic such that yunohost tools regen-conf nginx will call both the base hook and the custom hook

Apart from the maybe missing call to yunohost tools regen-conf nginx in the install script, that PR looks okay to me 👍

@oiseauroch
Copy link
Collaborator Author

!testme

@yunohost-bot
Copy link
Contributor

Meow 🐈
Test Badge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants